Scoped dependency fix#5
Open
legitosaurus wants to merge 2 commits into
Open
Conversation
Change fs util library from fs.extra to fs-extra.
Use ensureSymlink instead of symlink to allow linking of scoped npm packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fs.ensureSymlinkto ensure that scoped dependencies have the scope directory created.What issues does this PR fix or reference?
None - found while evaluating the package.
Previous Behavior
Links for scoped dependencies fail due to the scope/namespace directory not being created.
Example
./public/scripts/@microsoft/applicationinsights-web => ./node-modules/@microsoft/applicationinsights-web.The folder being linked
applicationinsights-webfails due to the parent directory./public/scripts/@microsoftnot being created/existing.New Behavior
Dependencies that are scoped will have the scope/namespace directory created (if required).
Using the previous behavior example (
@microsoft/applicationinsights-web), the directory./public/scripts/@microsoftwill be created first, then the symlink directoryapplicationinsights-web.Tests written?
No