Skip to content

Enable precise storage by passing Engine as a type parameter #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfc-gh-rnarubin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable precise storage by passing Engine as a type parameter #1287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions foyer-bench/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,9 @@ use exporter::PrometheusExporter;
#[cfg(target_os = "linux")]
use foyer::UringIoEngineConfig;
use foyer::{
BlockEngineConfig, Code, Compression, Device, DeviceBuilder, EngineConfig, FifoConfig, FifoPicker,
FileDeviceBuilder, FsDeviceBuilder, HybridCache, HybridCacheBuilder, HybridCachePolicy, HybridCacheProperties,
InvalidRatioPicker, IoEngineConfig, LfuConfig, LruConfig, NoopDeviceBuilder, PsyncIoEngineConfig, RecoverMode,
S3FifoConfig, Spawner, Throttle, TracingOptions,
BlockEngineConfig, Code, Compression, Device, DeviceBuilder, FifoConfig, FifoPicker, FileDeviceBuilder,
FsDeviceBuilder, HybridCache, HybridCacheBuilder, HybridCachePolicy, InvalidRatioPicker, IoEngineConfig, LfuConfig,
LruConfig, NoopDeviceBuilder, PsyncIoEngineConfig, RecoverMode, S3FifoConfig, Spawner, Throttle, TracingOptions,
};
use futures_util::future::join_all;
use itertools::Itertools;
Expand Down Expand Up @@ -606,7 +605,7 @@ async fn benchmark(args: Args) {
_ => unreachable!(),
};

let engine_config: Box<dyn EngineConfig<u64, Value, HybridCacheProperties>> = {
let engine_config = {
let mut builder = BlockEngineConfig::new(device)
.with_block_size(args.block_size.as_u64() as _)
.with_indexer_shards(args.shards)
Expand All @@ -623,8 +622,7 @@ async fn benchmark(args: Args) {
builder = builder.with_clean_block_threshold(args.clean_block_threshold);
}
builder
}
.boxed();
};

let mut builder = builder
.with_weighter(|_: &u64, value: &Value| u64::BITS as usize / 8 + value.len())
Expand Down
Loading
Loading