fix(sandbox): prevent E2B sync marker race - #339
Open
ShiroKSH wants to merge 1 commit into
Open
Conversation
ShiroKSH
marked this pull request as ready for review
July 11, 2026 14:19
Author
|
@frankbria We'd appreciate it if you could take a look at this pull request when you have a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The download scanned files against the previous marker, while acknowledgement advanced the marker to the later acknowledgement time. A remote write that landed after the scan but before acknowledgement could therefore be older than the new marker without ever being included in an archive.
The pending marker records the scan boundary up front. Acknowledgement atomically promotes that boundary, preserving at-least-once delivery and keeping repeated acknowledgements idempotent.
Validation