Skip to content

refactor runrecipes to ensure correct directory path #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AngeloHeringa merged 1 commit into from
Mar 24, 2025
Merged

refactor runrecipes to ensure correct directory path #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ Run recipes on your Frank!Framework project by providing the relative or absolut
After proving the path you should provide the target version of Frank!Framework to reference the needed recipes. This requires a certain syntax: [major version]_[minor version] (for example "7_4" references the recipes needed to migrate from 7.3.x to 7.4.x).
Optionally you can provide your current Frank!Framework version if you want to run a range of recipes, without this argument it only runs a single recipe for the specified minor version.

**Note: Not correctly ending the target path with a "\\" (for example: ..\..\myproject, instead of ..\..\myproject\\) when using runRecipes.bat will run the script in the parent directory (the wrong directory), and could cause unwanted changes to other projects!**

```cd .\reciperunner\```

```.\runRecipes.bat [relative path your project] [target Frank!Framework version] [current Frank!Framework version]```
Expand Down
6 changes: 3 additions & 3 deletions reciperunner/runRecipes.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
@echo off

REM Check if the argument is provided
if "%~dp1"=="" (
if "%~1"=="" (
echo Error: No target directory provided.
echo Usage: script.bat [target_directory]
echo Usage: .\runRecipes.bat [relative path your project] [target Frank!Framework version] [current Frank!Framework version]
exit /b 1
)

REM Store the current directory
set "SOURCE_DIR=%cd%"
REM Store the target directory from the argument
set "TARGET_DIR=%~dp1"
set "TARGET_DIR=%~f1"

REM Store target maven profile from argument
set "TARGET_PROFILE=%2"
Expand Down