Skip to content

Bench missing db_port attribute #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zaqoutabed wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Bench missing db_port attribute #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions agent/bench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ def __init__(self, name: str, server: Server, mounts=None):
self.apps_file = os.path.join(self.directory, "sites", "apps.txt")
self.bench_config_file = os.path.join(self.directory, "config.json")
self.config_file = os.path.join(self.directory, "sites", "common_site_config.json")
self.host = self.config.get("db_host", "localhost")
self.db_port = self.config.get("db_port", 3306)
self.docker_image = self.bench_config.get("docker_image")
self.mounts = mounts
if not (
os.path.isdir(self.directory)
Expand All @@ -67,6 +64,18 @@ def __init__(self, name: str, server: Server, mounts=None):
):
raise Exception

@property
def host(self):
return self.common_site_config.get("db_host", "localhost")

@property
def db_port(self):
return self.common_site_config.get("db_port", 3306)

@property
def docker_image(self):
return self.bench_config.get("docker_image")

@step("Deploy Bench")
def deploy(self):
return self.start()
Expand Down