fix(server): Shell escape docker login args (backport #534)

[mergify]

---

This is an automatic backport of pull request #534 done by [Mergify](https://mergify.com).

[greptile-apps]

Greptile Summary

Applies shlex.quote to all user-controlled arguments interpolated into docker CLI commands executed via subprocess.Popen(..., shell=True), closing shell injection vectors across docker login, docker pull, docker push, docker inspect, docker rmi, docker rm, and related grep pipelines.

• All changed call sites in server.py correctly wrap dynamic arguments with shlex.quote before f-string interpolation into shell commands.
• docker login now quotes the registry URL, username, and password; docker_inspect_manifest, docker inspect, docker rm, docker rmi, docker push, and docker pull each quote their respective image/container name arguments.

Confidence Score: 5/5

Straightforward, targeted shell-escaping fix with no logic changes — safe to merge.

Every dynamic argument passed to a shell=True docker command is now wrapped with shlex.quote. The fix is mechanical and complete across all affected call sites, with no new logic introduced.

No files require special attention.

Important Files Changed

Filename	Overview
agent/server.py	Adds shlex.quote to all docker command arguments (login credentials, image tags, container names, bench names) to prevent shell injection via the shell=True subprocess execution path.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[docker command with user-controlled arg] --> B{shlex.quote applied?}
    B -- Before PR: No --> C[f-string interpolated directly into shell command]
    C --> D[subprocess.Popen shell=True]
    D --> E[Shell injection possible]
    B -- After PR: Yes --> F[arg shell-escaped before interpolation]
    F --> D
    D --> G[Shell injection prevented]

Loading

_{Reviews (2): Last reviewed commit: "fix(server): add missing shlex import" | Re-trigger Greptile}

[ssiyad]

@copilot

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

Issue 1 of 1

agent/server.py:3-10
shlex is used in every changed call but is never imported in this file. Every shlex.quote() call will raise NameError: name 'shlex' is not defined at runtime, meaning docker login, push, pull, inspect, rm, rmi, and image-ls operations will all crash instead of running. The security fix is entirely non-functional without this import.

import contextlib
import json
import os
import platform
import shlex
import shutil
import subprocess
import tempfile
import time

[Copilot]

@copilot

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
...

Fixed in the latest commit — import shlex has been added to agent/server.py.