fix(build): Validate platform is arm64 or x86_64 (backport #535)#537
Merged
Conversation
(cherry picked from commit 904124b)
|
| Filename | Overview |
|---|---|
| agent/builder.py | Adds a ValueError guard validating that platform is "arm64" or "x86_64" before assigning to self.platform; change is correct and consistent with the existing Literal type annotation. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["ImageBuilder.__init__(platform)"] --> B{"platform in\n('arm64', 'x86_64')?"}
B -- No --> C["raise ValueError\n'Invalid platform ...'"]
B -- Yes --> D["self.platform = platform"]
D --> E["docker buildx build --platform {self.platform}"]
Reviews (1): Last reviewed commit: "fix(build): Validate platform is arm64 o..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #535 done by [Mergify](https://mergify.com).