refactor: Remove deprecated binlog endpoint (backport #538)#539
Merged
Conversation
In binlog v2, we have our custom indexer (cherry picked from commit 04b5a85)
|
| Filename | Overview |
|---|---|
| agent/database_server.py | Removes the search_binary_log method entirely; no remaining callers, binary_logs property is untouched. |
| agent/web.py | Removes the /database/binary/logs/<log> POST route; the sibling GET /database/binary/logs listing endpoint is unaffected. |
Sequence Diagram
sequenceDiagram
participant Client
participant web.py
participant DatabaseServer
Note over Client,DatabaseServer: REMOVED (deprecated)
Client->>web.py: "POST /database/binary/logs/{log}"
web.py->>DatabaseServer: search_binary_log(log, database, ...)
DatabaseServer-->>web.py: events[]
web.py-->>Client: JSON response
Note over Client,DatabaseServer: RETAINED
Client->>web.py: GET /database/binary/logs
web.py->>DatabaseServer: binary_logs (property)
DatabaseServer-->>web.py: log list
web.py-->>Client: JSON response
Reviews (1): Last reviewed commit: "refactor: Remove deprecated binlog endpo..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In binlog v2, we have our custom indexer
This is an automatic backport of pull request #538 done by Mergify.