-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Option to enable grouping and add multiple tasks to a row #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iaminamcom
wants to merge
8
commits into
frappe:master
Choose a base branch
from
iaminamcom:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey, nice changes! If you can resolve the conflicts, we'd really appreciate it. |
Yes it's public you can fork. Is there something I can do?
…On Wed, May 7, 2025 at 8:39 PM FabioL ***@***.***> wrote:
*loviuz* left a comment (frappe/gantt#448)
<#448 (comment)>
HI @iaminamcom <https://github.com/iaminamcom>, can you enable me to your
fork so I can try to resolve conflicts? I need this feature :-)
—
Reply to this email directly, view it on GitHub
<#448 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJCHJQPOIT7DM2R362OUHL25ISKBAVCNFSM6AAAAABQLXTOWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNJZGA4DMNRXGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Thank you!
M. Inam
|
@iaminamcom your changes aren't aligned with the latest version of Frappe Gantt (we had major refactors after your PR). If you could update your PR to make sure there are no conflicts, I'd appreciate that. |
Will this be merged into the main branch? I'd love this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was in need to add group so that I can add tasks to specify rows. I found #95 is still open and solutions there are working but not compatible with new version.
Here's an implementation which allow user to enable or disable grouping also fixes rows, lines issues.
What changed
You need to add following to options
and in tasks will be like