fix: Cannot create recurring Additional salary for new recurring period #2579
+13
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- validate_duplicate_additional_salary
ruchamahabal
reviewed
Jan 8, 2025
ruchamahabal
changed the title
|
@ruchamahabal it would be great if you could give this PR a review whenever you get the chance. Thank you 🙂 |
| } | ||
|
|
||
| if self.is_recurring: | ||
| filters["payroll_date"] = ["between", [self.from_date, self.to_date]] |
There was a problem hiding this comment.
This should actually also check for the other case. If my current additional salary is not recurring but there is a recurring additional salary already existing.
There was a problem hiding this comment.
@ruchamahabal I believe it is already covered in the method before this call. Are you referring to a different case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2578