fix: Roster path in Shift & Attendance workspace #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix relative URL to work behind a proxy
ruchamahabal
reviewed
Apr 8, 2025
|
I suspect the issue lies with the functions frappe.utils.generate_route or get_route. When operating behind a proxy, shortcut URLs that end with a trailing slash (/) are not correctly converted into fully qualified URLs. If the trailing slash is omitted, the URL is properly interpreted as a relative path. Change: After: |
ruchamahabal
changed the title
ruchamahabal
reviewed
Apr 8, 2025
| @@ -259,7 +259,7 @@ | |||
| "doc_view": "List", | |||
| "label": "Roster", | |||
| "type": "URL", | |||
| "url": "/hr/roster/" | |||
| "url": "/hr/roster" | |||
There was a problem hiding this comment.
You will also have to update modified timestamp for this json document for it to get synced on migrating sites
Also requesting you to move description to the main PR description section from the comment
And for future contributions please follow semantic commits: https://www.conventionalcommits.org/en/v1.0.0/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix relative URL to work behind a proxy