fix(payroll bank entry): ignore employee with zero payment amount #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkat102
force-pushed
the
zero-payment-bank-entry
branch
from
7878b2f to
915d7a3
Compare
|
@venkat102 can you add a test for this? |
venkat102
force-pushed
the
zero-payment-bank-entry
branch
from
97a84cf to
4c7f0de
Compare
@ruchamahabal added test for this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Unable to create bank entry when an employee has 0 payment amount
ref: 34459
Before:
zero-payment-bank-entry-issue.mp4
After:
zero-payment-bank-entry-fix.mp4
Backport needed for v15