Skip to content

fix: prevent multiple feedback submissions by checking existing submi… #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

PugazhendhiVelu
Copy link
Contributor

Issue:
The Submit Feedback button is still visible after feedback has been submitted.

ref: #2758

Before:

Before

After:

After

Backport needed: version-15

@PugazhendhiVelu PugazhendhiVelu marked this pull request as ready for review March 28, 2025 11:35
@venkat102 venkat102 force-pushed the validate-feedback-submission branch from 691232c to ace49bd Compare April 7, 2025 06:18
@PugazhendhiVelu PugazhendhiVelu force-pushed the validate-feedback-submission branch 2 times, most recently from 32d3dd1 to a9e6e15 Compare April 8, 2025 16:43
@PugazhendhiVelu PugazhendhiVelu force-pushed the validate-feedback-submission branch from a9e6e15 to d61b09c Compare April 15, 2025 11:59
@PugazhendhiVelu
Copy link
Contributor Author

Hi @ruchamahabal , can you please review this PR when you get a chance? Thanks!

@asmitahase
Copy link
Collaborator

Hi @PugazhendhiVelu, thanks for the contribution, could you please rebase the branch so this could be merged. Sincere apologies for the delay!

@PugazhendhiVelu PugazhendhiVelu force-pushed the validate-feedback-submission branch from b75ee8d to 7b98c28 Compare May 13, 2025 11:40
@PugazhendhiVelu
Copy link
Contributor Author

Hii @asmitahase , thanks for the response.

@asmitahase asmitahase merged commit 7e410b3 into frappe:develop May 13, 2025
4 checks passed
asmitahase added a commit that referenced this pull request May 13, 2025
…2921

fix: prevent multiple feedback submissions by checking existing submi… (backport #2921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants