reset editor when closing the window. fix #30 fix #29#32
Open
reset editor when closing the window. fix #30 fix #29#32
Conversation
Collaborator
Author
|
Note: travis builds fail because of a problem in their configuration, I think Note 2: tested and working on Windows 10 21H1 too. |
Collaborator
Author
|
I also fixed the crash on windows in issue #29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though it deletes and re-creates the editor object, it's a simple enough fix for now.
I also fixed the window size starting too small on macOS 11.4 (now it starts at a comfortable 600x400 with a strict minimum size of 300x200, so you don't get lost with a dialog you can't even see the content of)