-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin PyMuPDF and drop Ubuntu Focal support #1097
base: main
Are you sure you want to change the base?
Conversation
Unpin the PyMuPDF package that we vendor in our Debian packages. We originally pinned it to version 1.24.11, because it was the last version that supported Ubuntu Focal, but we can now unpin it, since we have dropped Ubuntu Focal support. Fixes #1018
@@ -55,13 +55,6 @@ | |||
HAMBURGER_MENU_SIZE = 30 | |||
|
|||
|
|||
WARNING_MESSAGE = """\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than removing the code, could it be better to keep it for future announces we would like to make, but for now it doesn't trigger?
&& pip install pipx \ | ||
&& rm -rf /var/lib/apt/lists/*; \ | ||
else true; fi' | ||
RUN pipx install poetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Maybe we should keep the mechanism in place to display announces, but other than that looks good.
Drop Ubuntu 20.04 (Focal) support, because it's nearing its end-of-life date. By doing so, we can remove several workarounds and notices we had in place for this version, and most importantly, remove the pin to our vendored PyMuPDF package.
Fixes #1018
Refs #1018
Refs #965