Skip to content

Commit

Permalink
Merge pull request #1340 from t-woerner/dns_over_tls_hotfix
Browse files Browse the repository at this point in the history
ipa* deployment roles: Hotfix for dns_over_tls (Freeipa#7343)
  • Loading branch information
varunmylaraiah authored Feb 11, 2025
2 parents e8688d4 + 3c50a81 commit feb33e4
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 1 deletion.
8 changes: 7 additions & 1 deletion roles/ipaclient/library/ipaclient_setup_nss.py
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,7 @@ def main():
options.no_sssd = False
options.sssd = not options.no_sssd
options.no_ac = False
options.dns_over_tls = False
nosssd_files = module.params.get('nosssd_files')
selinux_works = module.params.get('selinux_works')
krb_name = module.params.get('krb_name')
Expand Down Expand Up @@ -376,7 +377,12 @@ def main():
ssh_config_dir = paths.SSH_CONFIG_DIR
else:
ssh_config_dir = services.knownservices.sshd.get_config_dir()
update_ssh_keys(hostname, ssh_config_dir, options.create_sshfp)
argspec_update_ssh_keys = getargspec(update_ssh_keys)
# Hotfix for https://github.com/freeipa/freeipa/pull/7343
if "options" in argspec_update_ssh_keys.args:
update_ssh_keys(hostname, ssh_config_dir, options, cli_server[0])
else:
update_ssh_keys(hostname, ssh_config_dir, options.create_sshfp)

try:
os.remove(CCACHE_FILE)
Expand Down
7 changes: 7 additions & 0 deletions roles/ipareplica/module_utils/ansible_ipa_replica.py
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,13 @@ def knobs(self):
# ServerReplicaInstall
options.subject_base = None
options.ca_subject = None

# Hotfix for https://github.com/freeipa/freeipa/pull/7343
options.dns_over_tls = False
options.dns_over_tls_key = None
options.dns_over_tls_cert = None
options.dot_forwarders = None
options.dns_policy = None
# pylint: enable=attribute-defined-outside-init


Expand Down
7 changes: 7 additions & 0 deletions roles/ipaserver/module_utils/ansible_ipa_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,13 @@ def knobs(self):
# no_msdcs is deprecated
options.no_msdcs = False

# Hotfix for https://github.com/freeipa/freeipa/pull/7343
options.dns_over_tls = False
options.dns_over_tls_key = None
options.dns_over_tls_cert = None
options.dot_forwarders = None
options.dns_policy = None

# For pylint
options.external_cert_files = None
options.dirsrv_cert_files = None
Expand Down

0 comments on commit feb33e4

Please sign in to comment.