Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase task extra time to avoid job jumping to another runner #375

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Increase task extra time to avoid job jumping to another runner #375

merged 1 commit into from
Jun 10, 2020

Conversation

netoarmando
Copy link
Member

@netoarmando netoarmando commented Jun 5, 2020

Runners are considering jobs that are still being executed by another runner as stalled. Some of those jobs are about to time-out;
however, a new runner marks it as stalled and re-runs it, while the first runner is still running the job. Github doesn't receive an error/failure from the first runner, only the notification that a new runner is picking the job.

Issue: #365

Signed-off-by: Armando Neto [email protected]

@netoarmando netoarmando requested a review from f-trivino June 5, 2020 21:55
Runners are considering jobs that are still being executed
by another runner as stalled. Some of those jobs are about to time-out;
however, a new runner marks it as stalled and re-runs it, while the
first runner is still running the job. Github doesn't receive an
error/failure from the first runner, only the notification that a
new runner is picking the job.

Issue: #365

Signed-off-by: Armando Neto <[email protected]>
Copy link
Contributor

@f-trivino f-trivino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @netoarmando for the patch.

@netoarmando netoarmando merged commit 689d9df into freeipa:master Jun 10, 2020
@netoarmando netoarmando deleted the increase-extra-timeout branch June 10, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants