Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit test] 'IpaTextboxList' component #643

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

carma12
Copy link
Collaborator

@carma12 carma12 commented Feb 18, 2025

The IpaTextboxList component must have a test to check its functionality. This has been created to check the following cases:

  • It should render the component
  • It should add an element to the list
  • It should remove an element from the list
  • It should change the value of an element in the list
  • It should validate the list

In order to have a better organization of the components
and its tests, those should be under a folder with the
same name as the component itsef. Also, some affected
components imports must be corrected to the new path.

Signed-off-by: Carla Martinez <[email protected]>
@carma12 carma12 added needs-review This PR is waiting on a review tests PR related to testing labels Feb 18, 2025
The `IpaTextboxList` component must have a test
to check its functionality.

Signed-off-by: Carla Martinez <[email protected]>
@carma12 carma12 force-pushed the unit-test-IpaTextboxList branch from cf2e85b to 75bc4a8 Compare February 18, 2025 16:45
@carma12 carma12 requested a review from duzda February 18, 2025 16:46
Copy link
Contributor

@duzda duzda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@carma12 carma12 merged commit 99a9de0 into freeipa:main Feb 19, 2025
4 checks passed
@carma12 carma12 removed the needs-review This PR is waiting on a review label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests PR related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants