Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to login page after pwd reset #647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

carma12
Copy link
Collaborator

@carma12 carma12 commented Feb 20, 2025

When a given user with OTP token is resetting its password, it was automatically auto-login with the new credentials. The new solution should redirect to the login page after a password reset to allow users to explicitly introduce the new password.

Fixes: #645

@carma12 carma12 added the needs-review This PR is waiting on a review label Feb 20, 2025
@carma12 carma12 requested a review from miskopo February 20, 2025 08:57
@carma12 carma12 force-pushed the fix-otp-issue-645 branch 2 times, most recently from f5d5f59 to a8edf37 Compare February 20, 2025 09:13
Copy link
Member

@miskopo miskopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch works perfectly, however, since the user is now redirected back to the login page, button Reset password and Log in does not make sense in this context.

@carma12
Copy link
Collaborator Author

carma12 commented Feb 20, 2025

The patch works perfectly, however, since the user is now redirected back to the login page, button Reset password and Log in does not make sense in this context.

@miskopo - This has been corrected in the code. Tests are launching now...

When a given user with OTP token is resetting its
password, it was automatically auto-login with
the new credentials. The new solution should
redirect to the login page after a password
reset to allow users to explicitely introduce
the new password.

Fixes: freeipa#645
Signed-off-by: Carla Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review This PR is waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password reset for OTP enabled user is looping
2 participants