Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request, titled "opt avg_1d", focuses on optimizing the avg_1d function within graph/node.cpp by removing redundant debug and initialization actions.
- Removed commented debug node pushes for tensor results.
- Removed FillWeightAction calls for sum and mask tensors.
- Removed an unused commented parameter in SoftmaxBackwardAction.
Comments suppressed due to low confidence (1)
graph/node.cpp:465
- Verify that the removal of the FillWeightAction initializations for sum_tensor and mask_sum_tensor does not leave these tensors uninitialized, especially if their default state is relied upon later.
gCreateAction(
new FillWeightAction(
sum_tensor,
"fill",
0.0f,
0
)
);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.