Skip to content

opt avg_1d#27

Merged
freelw merged 2 commits intomainfrom
wangli_dev_20250611
Jun 11, 2025
Merged

opt avg_1d#27
freelw merged 2 commits intomainfrom
wangli_dev_20250611

Conversation

@freelw
Copy link
Copy Markdown
Owner

@freelw freelw commented Jun 11, 2025

No description provided.

@freelw freelw requested a review from Copilot June 11, 2025 06:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request, titled "opt avg_1d", focuses on optimizing the avg_1d function within graph/node.cpp by removing redundant debug and initialization actions.

  • Removed commented debug node pushes for tensor results.
  • Removed FillWeightAction calls for sum and mask tensors.
  • Removed an unused commented parameter in SoftmaxBackwardAction.
Comments suppressed due to low confidence (1)

graph/node.cpp:465

  • Verify that the removal of the FillWeightAction initializations for sum_tensor and mask_sum_tensor does not leave these tensors uninitialized, especially if their default state is relied upon later.
gCreateAction(
            new FillWeightAction(
                sum_tensor,
                "fill",
                0.0f,
                0
            )
        );

@freelw freelw merged commit 12bd2f2 into main Jun 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants