Skip to content

fix #30#31

Merged
freelw merged 1 commit intomainfrom
wangli_dev_20250615
Jun 15, 2025
Merged

fix #30#31
freelw merged 1 commit intomainfrom
wangli_dev_20250615

Conversation

@freelw
Copy link
Copy Markdown
Owner

@freelw freelw commented Jun 15, 2025

fix #30

@freelw freelw requested a review from Copilot June 15, 2025 00:47
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #30 by improving error handling for compute pipeline state creation in the Metal backend.

  • Added conditional logging to differentiate between known error details and unknown errors.
  • Ensured that a more descriptive message is printed prior to throwing an exception.
Comments suppressed due to low confidence (1)

backends/gpu/metal/kernel_ops.cpp:38

  • Consider incorporating the error details into the exception message being thrown so that the exception provides richer context for debugging.
if (error) {

@freelw freelw merged commit 28d0821 into main Jun 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If error remains null, calling localizedDescription() will crash. Add a null check for error before dereferencing.

2 participants