Skip to content

fix #29 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freelw merged 1 commit into from
Jun 15, 2025
Merged

fix #29 #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backends/gpu/metal/kernel_ops.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ MTL::ComputeCommandEncoder* MetalKops::prepare(
throw std::runtime_error("Failed to create compute pipeline state");
}
encoder->setComputePipelineState(pipelineState);
pipelineState->release();
Copy link

Copilot AI Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using an RAII wrapper or smart pointer for MTL::ComputePipelineState objects to automatically manage reference counting and avoid manual release() calls.

Copilot uses AI. Check for mistakes.
return encoder;
}

Expand Down