Skip to content

Conversation

JoeCap08055
Copy link
Collaborator

@JoeCap08055 JoeCap08055 commented Aug 13, 2025

Goal

The goal of this PR is to implement the design described here

Tracking epic: #2550

Checklist

  • Updated Pallet Readme?
  • Updated js/api-augment for Custom RPC APIs?
  • Design doc(s) updated?
  • Unit Tests added?
  • e2e Tests added?
  • Benchmarks added?
  • Spec version incremented?

@JoeCap08055 JoeCap08055 requested a review from wilwade as a code owner August 15, 2025 16:25
# Goal
The goal of this PR is to implement *only* the *types* and *pallet
storage* for the following new on-chain entities:
* Intents
* IntentGroups

Closes #2561

**NOTE:** No tests or benchmarks added in this PR, as it only contains
types and storage, no executable runtime code (coming in a separate PR)

# Checklist
- [x] Updated Pallet Readme?
- [ ] Updated js/api-augment for Custom RPC APIs?
- [x] Design doc(s) updated?
- [ ] Unit Tests added?
- [ ] e2e Tests added?
- [ ] Benchmarks added?
- [ ] Spec version incremented?
# Conflicts:
#	runtime/frequency/src/lib.rs
…ntGroup) (#2563)

# Description
This PR implments type, storage, and runtime RPCs for mapping fully
qualified names of the form `<protocol>.<descriptor>` to Intents or
IntentGroups.

Additional tests & support will be the subject of an upcoming PR; this
is only merging to a feature branch.

Closes #2562 

# Discussion

- <!-- List discussion items -->

# Checklist
- [ ] Updated Pallet Readme?
- [ ] Updated js/api-augment for Custom RPC APIs?
- [ ] Design doc(s) updated?
- [ ] Unit Tests added?
- [ ] e2e Tests added?
- [ ] Benchmarks added?
- [ ] Spec version incremented?
@JoeCap08055 JoeCap08055 force-pushed the feat/schemas-permissions-development branch from b91436b to 6307cc1 Compare August 20, 2025 15:29
@JoeCap08055 JoeCap08055 marked this pull request as draft August 20, 2025 15:30
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 87.94118% with 41 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pallets/schemas/src/lib.rs 93.66% 19 Missing ⚠️
common/primitives/src/schema.rs 0.00% 11 Missing ⚠️
pallets/schemas/src/types.rs 62.06% 11 Missing ⚠️
Files with missing lines Coverage Δ
common/primitives/src/schema.rs 43.75% <0.00%> (-6.98%) ⬇️
pallets/schemas/src/types.rs 85.56% <62.06%> (-10.33%) ⬇️
pallets/schemas/src/lib.rs 90.46% <93.66%> (+2.96%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 20, 2025
# Goal
The goal of this PR is to implement the extrinsics, RPCs and unit tests
for Intents and IntentGroups.

Closes #2564 

# Discussion

- <!-- List discussion items -->

# Checklist
- [x] Updated Pallet Readme?
- [ ] Updated js/api-augment for Custom RPC APIs?
- [ ] Design doc(s) updated?
- [x] Unit Tests added?
- [ ] e2e Tests added?
- [x] Benchmarks added?
- [ ] Spec version incremented?
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 29, 2025
# Goal
The goal of this PR is to update the types, extrinsics, and runtime APIs
for the Schemas pallet to conform to the new design

Closes #2580 

# Checklist
- [ ] Updated Pallet Readme?
- [x] Updated js/api-augment for Custom RPC APIs?
- [ ] Design doc(s) updated?
- [ ] Unit Tests added?
- [ ] e2e Tests added?
- [x] Benchmarks added?
- [ ] Spec version incremented?

---------

Co-authored-by: Shannon Wells <[email protected]>
Co-authored-by: Aramik <[email protected]>
try-runtime-create-snapshot-paseo-testnet \
try-runtime-create-snapshot-westend-testnet \
try-runtime-create-snapshot-mainnet: check-try-runtime-installed check-onfinality-api-key
try-runtime create-snapshot $(PALLET_FLAGS) --uri $(URI) $(CHAIN)-$(SNAPSHOT_PALLETS).state
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just when the need rise 🥇

# Goal
The goal of this PR is to migrate the `messages` pallet to add
`schema_id` to message storage, and use `intent_id` as the index
instead.

Existing index values do not need to be changed, as the `schemas` pallet
migration ensures that the chain is seeded with Intent IDs that match
existing Schema IDs

Related to #2581 

# Checklist
- [ ] Updated Pallet Readme?
- [ ] Updated js/api-augment for Custom RPC APIs?
- [ ] Design doc(s) updated?
- [x] Unit Tests added?
- [ ] e2e Tests added?
- [x] Benchmarks added?
- [ ] Spec version incremented?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants