-
Notifications
You must be signed in to change notification settings - Fork 22
[DO NOT MERGE] updated: storage benchmarks #2611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Also to note, it's not just the increase in MSAs that contributes to the growth in keys. Freesky is posting tons of content; right now on testnet there are over 3.4M message keys and growing daily at a significant clip. This is significant, because while the growth in new accounts and graphs may plateau at points, presumably the amount of content will continue to grow unbounded... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we estimate, based on the freesky usage, how comparatively fast capacity will drain based on these new weights? Might be good to have numbers like that somewhere. Not a blocking comment obviously.
}); | ||
|
||
it('should allow retiring MSA after additional keys have been deleted and tokens withdran', async function () { | ||
it.skip('should allow retiring MSA after additional keys have been deleted and tokens withdran', async function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried multiple attempts to fix this test but for it always found a way to fail in one way or another. Would appreciate if you know how to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving all of them into sudo.test.ts
because if a test is using sudo key it should be inside that file so that it doesn't error in parallel mode.
Based on my calculations presented in the PR |
Pallet base reads
|
No child tree read weights
|
Goal
The goal of this PR is to update the database benchmarks
Closes #2606
Discussion
Some considerations
Checklist