update mocks to have >1 ED and update breaking tests #2619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
claireclark1
requested review from
shannonwells,
mattheworris,
enddynayn and
aramikm
and removed request for
wilwade
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
mattheworris
reviewed
Oct 2, 2025
| pallet_balances::GenesisConfig::<Test> { | ||
| balances: vec
There was a problem hiding this comment.
Note: balances pallet will not allow accounts to be created with less than ED, now 10 is the minimum.
mattheworris
reviewed
Oct 2, 2025
| PalletBalances::can_withdraw(&CHARLIE, 30), | ||
| WithdrawConsequence::ReducedToZero(0) | ||
| ); | ||
| assert_eq!(PalletBalances::can_withdraw(&CHARLIE, 29), WithdrawConsequence::Success); |
There was a problem hiding this comment.
Note: can_withdraw maxes out at 20 because of 10 ED (30 - ED(10) = 20). The ReducedToZero(0) error validates that the entire balance is available, else the error returned would be WithdrawConsequence:Frozen as in the above cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to update mocks to have >1 ED so that we can test over and under cases in the future.
Closes #1852
Discussion
Checklist