syncing with main branch #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added doc for DoNotClearSuperAgent
Add references to the issue being addressed and better comments and variablenames.
Don't infer Content-Type when set explicitly
updating some of the English
Handle error in byte stream (failed transfer of a chunk)
"Clone" the SuperAgent for reuse
chore: bump moul.io/http2curl dependency
please do not ToLower, the key should be same with `json` tags.
Add possibility to use fieldname file (not change it to file1, file2,…
add context support
Fix wrong example
Don't ToLower
This commit upgrades the project to Go version 1.24.3 from 1.22.0.
Key changes include:
- Updated `go.mod` to specify Go 1.24.3.
- Removed legacy version-specific files (e.g., `gorequest_client_go1.2.go`, `gorequest_transport_go1.8.go`, etc.).
- Consolidated functionality from these deleted files into `gorequest.go`:
- Added `safeModifyHttpClient()` to handle client cloning correctly.
- Added `Timeout()` method for `SuperAgent` using the standard `http.Client.Timeout`.
- Added `safeModifyTransport()` to handle transport cloning, ensuring relevant fields for Go 1.24.3 are copied.
- Ran `go mod tidy` to update dependencies and `go.sum`.
- Fixed test failures in `gorequest_test.go` related to non-constant format strings in `t.Errorf` and `t.Fatalf` calls by using `fmt.Sprintf`.
- Corrected a key casing issue in `TestQueryFunc` that caused test failures after initial format string fixes.
All tests pass with Go 1.24.3 after these changes.
When multiple Host headers were set, the first value was being used instead of the last. This has been corrected to use the last value, which is the expected behavior. A new test case has been added to verify this fix.
Upgraded the `go.mod` file to specify Go version 1.25.5, which is the latest stable version. This ensures the project uses the most up-to-date Go toolchain. Ran `go mod tidy` to synchronize dependencies and verified that all tests pass with the new version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.