Practical 1 on segmentation added. #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Comment: For pragmatic_segmenter did you use the English rules ? I don't think there are Ukrainian rules, but perhaps it might work better with the Russian rules than the English rules? |
Author
|
I followed the given instructions on the practical: https://ftyers.github.io/2018-komp-ling/practicals/segmentation.html and didn't know that I could change the rules, but now I see that maybe I could change the language in segmenter.rb file to Russian. Will it change the English rules to the Russian ones? I will try it today or tomorrow. Thank you! |
Added the result of Pragmatic Segmenter after changing its language into Russian
Author
|
I have added more results of Pragmatic Segmenter. Do I need to make a new pull-request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Fran! Here is my report on Practical 1. I'm so sorry to be late. It was very new and very difficult for me, but I will work on it more. I hope you will check my report. I will be waiting for your comments.
Thank you in advance.
Ann Nikolaeva