Better handling of config files in tgt-admin #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 22, 2025 17:21
# Create a target
<target iqn.2007-03:virtual-tape:hostname>
# Create a tape drive and give it a nice name
# The tape starts out without a backing store file, i.e. no tape loaded
<backing-store NONE:0>
lun 1
device-type tape
vendor_id IBM
product_id ULT3580-TD8
product_rev 2160
scsi_sn XYZZY_1
removable 1
</backing-store>
<backing-store NONE:1>
lun 2
device-type tape
vendor_id IBM
product_id ULT3580-TD8
product_rev 2160
scsi_sn XYZZY_2
removable 1
</backing-store>
# We need a backing store file for the media changer
#dd if=/dev/zero of=$HOME/smc bs=1k count=1
# Create the SMC device and give it a nice name
<backing-store /root/smc>
lun 3
device-type changer
vendor_id STK
product_id L700
product_rev 0010
scsi_sn XYZZY_0
removable 1
# Add a Data Transfer devices (2 drives)
params element_type=4,start_address=1,quantity=2
# Specify that the TAPEs above (LUN 1/2) are the data transfer devices we created
params element_type=4,address=1,tid=${tid},lun=1
params element_type=4,address=2,tid=${tid},lun=2
# Medium Transport Elements (robot arm / picker)
params element_type=1,start_address=16,quantity=1
# define path to virtual media
params media_home=/root/media
# Storage Elements - 8 starting at addr 1024
params element_type=2,start_address=1024,quantity=8
# Add 'media' to slots 1-3 and leave the other 5 slots empty
# slot 1
params element_type=2,address=1024,barcode=tape001
# slot 2
params element_type=2,address=1025,barcode=tape002
# slot 3
params element_type=2,address=1026,barcode=tape003
</backing-store>
</target>
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits here.
The first improves the config file handling, in particular, it avoids things like executing code supplied in the config file via shell escapes.
(I don't consider this a security risk as the config files are owned by root *on debian at least) but a system that allowed other users to change these files would give a local root compromise)
The second allows a tape changer VTL to be defined in the config file (I've included my config file in the commit message)
Note that I'm including them both together because I've never tests with them separate, the first one that avoids shell escapes from the config file came about because of me wanting the second one.