Install examples in documentation directory #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples do not belong in /etc/tgt on many systems now, so move them to /usr/share/doc/packages/tgt, but default, though it can still be overriden and set to /etc/tgt
fujita
reviewed
Mar 26, 2025
| @@ -1,4 +1,5 @@ | |||
| sysconfdir ?= /etc | |||
| docdatadir ?= /usr/share/doc/packages | |||
There was a problem hiding this comment.
/usr/share/doc/packages/tgt/examples ?
/usr/share/doc/tgt/examples is more general?
|
I cannot speak to what is more general, since I almost exclusively deal with SUSE/SLE/Tumbleweed. Our distro uses /usr/share/doc/packages//... But feel free to make it something you think is more general. I can always modify it when packaging our version. |
|
Would you like me to update my submission to use the directory you requested? |
|
merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples do not belong in /etc/tgt on many systems now, so move them to /usr/share/doc/packages/tgt, but default, though it can still be overriden and set to /etc/tgt