forked from spring-cloud/spring-cloud-release
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Ryan Baxter
authored
Feb 7, 2018
1 parent
1ebfb6b
commit 1f23e32
Showing
1 changed file
with
7 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,15 +9,15 @@ follow the guidelines below. | |
|
||
## Sign the Contributor License Agreement | ||
Before we accept a non-trivial patch or pull request we will need you to sign the | ||
https://cla.pivotal.io/sign/spring[Contributor License Agreement]. | ||
[Contributor License Agreement](https://cla.pivotal.io/sign/spring). | ||
Signing the contributor's agreement does not grant anyone commit rights to the main | ||
repository, but it does mean that we can accept your contributions, and you will get an | ||
author credit if we do. Active contributors might be asked to join the core team, and | ||
given the ability to merge pull requests. | ||
|
||
## Code of Conduct | ||
This project adheres to the Contributor Covenant https://github.com/spring-cloud/spring-cloud-build/blob/master/docs/src/main/asciidoc/code-of-conduct.adoc[code of | ||
conduct]. By participating, you are expected to uphold this code. Please report | ||
This project adheres to the Contributor Covenant [code of | ||
conduct](https://github.com/spring-cloud/spring-cloud-build/blob/master/docs/src/main/asciidoc/code-of-conduct.adoc). By participating, you are expected to uphold this code. Please report | ||
unacceptable behavior to [email protected]. | ||
|
||
## Code Conventions and Housekeeping | ||
|
@@ -27,10 +27,8 @@ added after the original pull request but before a merge. | |
* Use the Spring Framework code format conventions. If you use Eclipse | ||
you can import formatter settings using the | ||
`eclipse-code-formatter.xml` file from the | ||
https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/master/spring-cloud-dependencies-parent/eclipse-code-formatter.xml[Spring | ||
Cloud Build] project. If using IntelliJ, you can use the | ||
http://plugins.jetbrains.com/plugin/6546[Eclipse Code Formatter | ||
Plugin] to import the same file. | ||
[Spring Cloud Build](https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/master/spring-cloud-dependencies-parent/eclipse-code-formatter.xml) project. If using IntelliJ, you can use the | ||
[Eclipse Code Formatter Plugin](http://plugins.jetbrains.com/plugin/6546) to import the same file. | ||
* Make sure all new `.java` files to have a simple Javadoc class comment with at least an | ||
`@author` tag identifying you, and preferably at least a paragraph on what the class is | ||
for. | ||
|
@@ -42,6 +40,6 @@ added after the original pull request but before a merge. | |
* A few unit tests would help a lot as well -- someone has to do it. | ||
* If no-one else is using your branch, please rebase it against the current master (or | ||
other target branch in the main project). | ||
* When writing a commit message please follow http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html[these conventions], | ||
* When writing a commit message please follow [these conventions](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html), | ||
if you are fixing an existing issue please add `Fixes gh-XXXX` at the end of the commit | ||
message (where XXXX is the issue number). | ||
message (where XXXX is the issue number). |