-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue track point button and other new features #127
Draft
AnniekStok
wants to merge
29
commits into
main
Choose a base branch
from
continue_track_point_button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bute anything and is complicated to keep in sync
…to TrackPoints and TrackLabels
…g tracks vs starting a new track when adding a new node with a point
…(intersection between display mode all vs lineage and visibility in the plane sliders)
…tute for TrackGraph layers in the orthogonal views, to make sure the layer indices in the orthogonal views always match with those of the main viewer
… do not adjust the camera view
…ing to a node, so that the cross widget (if present) can update its location
…ifferent viewer models in the orthogonal views
… select/deselect nodes. When dragged however, do not alter the selection, as this is likely aiming to adjust the viewer angle when in 3D mode
… people first open images and then the plugin
… while not in select mode
…tract track_ids from node ids
…ansparency of 0 after hiding/showing the cross) and use line vector style
…r visible nodes in the TrackPoints layer when no TrackLabels layer is present to retrieve tracksviewer from
… when using the navigation keybinds
…up only in the case there is a trackpoints layer without a tracklabels layer in the tracksviewer
…gonal views to allow moving a point from any views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains several new features originally put together to customize the plugin to help a colleague with his use case. The new features include:
A now (hopefully) bug free version of the 3D orthogonal views and 3D clipping plane views with following functionalities:
orthogonal views:
clipping planes:
a radiobutton group to choose between 'continue tracks' vs 'start new tracks' when tracking with points (only visible if there is no TrackLabels together with TrackPoints).
simplified treewidget range updates: when updating the selection, it checks if all those nodes are still in view. If not, autoRange() is called (instead of setting a customized range for the selected nodes, which is often zoomed in too far and not helpful).
If you click outside a label or point in the TrackLabels or TrackPoints layer, the selected_nodes are reset.
when you export to CSV, the node color and lineage are also included. The lineage_id is defined as the track_id of the earliest known predecessor (using the get_lineage_id function in SolutionTracks).
Note: in order to filter nodes in the clipping planes, I used the tracks_df dataframe that was originally on the treewidget. Instead, I moved it to the tracks_viewer in order to be able to use it elsewhere. Also, I needed a reference to the tracks_viewer in the run_viewer to be able to pass on the colormap when exporting to CSV.
I am keeping it in this draft pull request until we have settled on which of these features should go to main, and then I can add them separately.