Rwap patch 1 #319
Draft
Rwap patch 1 #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine suggested changes to take account of issues with the original jquery-ui-touch-punch.js which has not been updated since 2014 - https://github.com/furf/jquery-ui-touch-punch
Lines dealing with "fix for zoomed devices while dragging" prevented jQuery ui sortable from moving items after you drag them to a new position
This fixes the issue: furf#315 where the Apple Pencil triggers a touchmove event and you may struggle to trigger a click with the pencil
Update for Apple Pencil
Previous release had an issue where clicking through to an input or a button (for example the close button on jQuery.ui dialog boxes) was not being recognised as a click. Incorporated another fix from the v0.2.3 branch so the code now treats anything as a click if (a) they leave theri finger on the control for less than 500ms, or (b) they do not move their finger more than 10 pixels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.