fix get navItem object bug by Navigation.get(target) method. #1410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I want to use the
get(target: string)
method innavigation.js
to get the target navItem I encountered a bug, the method provides two means of querying based on theid
orhref
attributes of thenavItem
, when I need to query based on theid
I need to manually add the # character, while at this time the target is no longer equal to the id value of the target navItem. So I restore the target value after the determination is over:epub.js/src/navigation.js
Line 90 in f09089c
and before calling getByIndex:
epub.js/src/navigation.js
Line 96 in f09089c