-
Notifications
You must be signed in to change notification settings - Fork 0
Support conventional server URL variable #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dd1e949
to
a10b391
Compare
Job Summary for GradleCheck PR :: kotlin-tests |
Job Summary for GradleCheck PR :: kotlin-tests |
Job Summary for GradleCheck PR :: kotlin-tests
|
Job Summary for GradleCheck PR :: kotlin-tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames the server URL configuration to align with official Develocity tooling conventions. The changes replace Config.apiUrl
and DEVELOCITY_API_URL
with Config.server
and DEVELOCITY_URL
respectively, while also strengthening type safety by using URI
instead of String
for URL handling and improving URL validation.
- Renamed environment variable from
DEVELOCITY_API_URL
toDEVELOCITY_URL
- Changed
Config.apiUrl
toConfig.server
withURI
type instead ofString
- Updated URL validation to enforce base URLs without paths or query parameters
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
library/src/main/kotlin/com/gabrielfeo/develocity/api/Config.kt | Core configuration changes: renamed apiUrl to server, added URI validation, updated documentation |
library/src/main/kotlin/com/gabrielfeo/develocity/api/internal/Retrofit.kt | Updated Retrofit configuration to use new server URI property |
library/src/test/kotlin/com/gabrielfeo/develocity/api/ConfigTest.kt | Updated tests for new server property and added comprehensive URL validation tests |
library/src/test/kotlin/com/gabrielfeo/develocity/api/RetrofitTest.kt | Updated tests to use new environment variable and simplified URL handling |
library/src/test/kotlin/com/gabrielfeo/develocity/api/DevelocityApiTest.kt | Updated error message assertions for new environment variable |
library/api/library.api | Updated public API definitions to reflect Config property type changes |
.github/workflows/publish-library.yml | Updated CI environment variable reference |
.github/workflows/pr.yml | Updated CI environment variable reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
As follow-up to #455 / #338, support the conventional server URL variable that's already set up for official Develocity tooling, such as
common-custom-user-data-gradle-plugin
with a set Develocity URL overrideConfig.apiUrl
andDEVELOCITY_API_URL
are renamed toConfig.server
andDEVELOCITY_URL
for consistency with official Develocity tooling nomenclature.Config.server
is strongly typed as a URI and validation is improved.