Skip to content

Conversation

gabrielfeo
Copy link
Owner

@gabrielfeo gabrielfeo commented Aug 26, 2025

As follow-up to #455 / #338, support the conventional server URL variable that's already set up for official Develocity tooling, such as

Config.apiUrl and DEVELOCITY_API_URL are renamed to Config.server and DEVELOCITY_URL for consistency with official Develocity tooling nomenclature.

Config.server is strongly typed as a URI and validation is improved.

@gabrielfeo gabrielfeo force-pushed the gf/conventional-url-setting branch from dd1e949 to a10b391 Compare August 26, 2025 19:53
Copy link
Contributor

Job Summary for Gradle

Check PR :: kotlin-tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
develocity-api-kotlin check 9.0.0 Build Scan published
dak-example-gradle-project dependencies --configuration runtimeClasspath 8.14.3 Build Scan not published
dak-example-gradle-task-main-…
:buildSrc:dependencies --configuration runtimeClasspath 8.14.3 Build Scan not published
dak-example-gradle-project run 8.14.3 Build Scan not published
dak-example-gradle-task-main-…
userBuildPerformanceMetrics 8.14.3 Build Scan not published
dak-example-gradle-task-main-…
userBuildPerformanceMetrics --user runner --period=-1d 8.14.3 Build Scan not published

Copy link
Contributor

Job Summary for Gradle

Check PR :: kotlin-tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
develocity-api-kotlin check 9.0.0 Build Scan published
dak-example-gradle-task-main-…
:buildSrc:dependencies --configuration runtimeClasspath 8.14.3 Build Scan not published
dak-example-gradle-project dependencies --configuration runtimeClasspath 8.14.3 Build Scan not published
dak-example-gradle-project run 8.14.3 Build Scan not published
dak-example-gradle-task-main-…
userBuildPerformanceMetrics 8.14.3 Build Scan not published
dak-example-gradle-task-main-…
userBuildPerformanceMetrics --user runner --period=-1d 8.14.3 Build Scan not published

Copy link
Contributor

Job Summary for Gradle

Check PR :: kotlin-tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
develocity-api-kotlin check 9.0.0 Build Scan published

Copy link
Contributor

Job Summary for Gradle

Check PR :: kotlin-tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
develocity-api-kotlin check 9.0.0 Build Scan published

@gabrielfeo gabrielfeo marked this pull request as ready for review August 28, 2025 18:50
@gabrielfeo gabrielfeo requested a review from Copilot August 28, 2025 18:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the server URL configuration to align with official Develocity tooling conventions. The changes replace Config.apiUrl and DEVELOCITY_API_URL with Config.server and DEVELOCITY_URL respectively, while also strengthening type safety by using URI instead of String for URL handling and improving URL validation.

  • Renamed environment variable from DEVELOCITY_API_URL to DEVELOCITY_URL
  • Changed Config.apiUrl to Config.server with URI type instead of String
  • Updated URL validation to enforce base URLs without paths or query parameters

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
library/src/main/kotlin/com/gabrielfeo/develocity/api/Config.kt Core configuration changes: renamed apiUrl to server, added URI validation, updated documentation
library/src/main/kotlin/com/gabrielfeo/develocity/api/internal/Retrofit.kt Updated Retrofit configuration to use new server URI property
library/src/test/kotlin/com/gabrielfeo/develocity/api/ConfigTest.kt Updated tests for new server property and added comprehensive URL validation tests
library/src/test/kotlin/com/gabrielfeo/develocity/api/RetrofitTest.kt Updated tests to use new environment variable and simplified URL handling
library/src/test/kotlin/com/gabrielfeo/develocity/api/DevelocityApiTest.kt Updated error message assertions for new environment variable
library/api/library.api Updated public API definitions to reflect Config property type changes
.github/workflows/publish-library.yml Updated CI environment variable reference
.github/workflows/pr.yml Updated CI environment variable reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gabrielfeo gabrielfeo enabled auto-merge (squash) August 28, 2025 19:03
@gabrielfeo gabrielfeo merged commit e36aaff into main Aug 28, 2025
7 checks passed
@gabrielfeo gabrielfeo deleted the gf/conventional-url-setting branch August 28, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant