Skip to content

initial ONNX support#13

Open
Hoeze wants to merge 8 commits intomasterfrom
onnx_support
Open

initial ONNX support#13
Hoeze wants to merge 8 commits intomasterfrom
onnx_support

Conversation

@Hoeze
Copy link
Copy Markdown

@Hoeze Hoeze commented May 19, 2023

The prediction results do not match yet, see interpretml/ebm2onnx#8

@Hoeze Hoeze marked this pull request as ready for review August 9, 2023 17:36
@Hoeze
Copy link
Copy Markdown
Author

Hoeze commented Aug 9, 2023

@WagnerNils Can you merge this please?
This converts your models to ONNX and removes the need to install any interpret package for pure inference.

Fun fact:
Did you know that "splice_site_is_expressed" in your EBM gets converted from int -> float -> string -> int?
E.g. splice_site_is_expressed == 1 (int) -> 1.0 (float) -> "1.0" (string) -> 0 (int) 🤦
I manually fixed this in the onnx models using onnx-modifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant