fix: optimize weight consumption on process_votes in conviction voting#1423
Merged
fix: optimize weight consumption on process_votes in conviction voting#1423
Conversation
|
Crate versions that have been updated:
Runtime version has been increased. |
cl0w5
approved these changes
Apr 16, 2026
Contributor
There was a problem hiding this comment.
This PR doesn't fixes #1341 , we are still processing all votes on vote.
This PR improves benchmarks because try_access_poll() is doing unnecessary write so your improvement is ok but it's not fixing linked issue.
|
Quick benchmark at commit e339861 has been executed successfully. |
F3Joule
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces new
GetReferendumStateimpl:DirectReferendumStatusthat reads referenda state using direct access toReferendumInfoForinstead of theframe_support::traits::voting::Pollingabstraction, which implementation inpallet_conviction_votingcaused extra writes to happen.Related Issue
Related to #1341. Not a direct fix
How Has This Been Tested?
No existing regression tests failed. Weights updated as expected.