Add additional argument to add_liquidity_stableswap_omnipool_and_join_farms#3296
Open
vkulinich-cl wants to merge 19 commits into
Open
Add additional argument to add_liquidity_stableswap_omnipool_and_join_farms#3296vkulinich-cl wants to merge 19 commits into
vkulinich-cl wants to merge 19 commits into
Conversation
❌ Deploy Preview for next-hydration failed. Why did it fail? →
|
jvonasek
requested changes
Jan 27, 2026
| const addebleReserves = useAddableStablepoolTokens(stableswapId, reserves) | ||
| const { account } = useAccount() | ||
| const meta = getAssetWithFallback(stableswapId) | ||
| const getOmnipoolGetShares = useLiquidityOmnipoolShares(stableswapId) |
Comment on lines
+116
to
+118
| const position = positionId | ||
| ? omnipoolPositions.find((position) => position.positionId === positionId) | ||
| : undefined |
Collaborator
There was a problem hiding this comment.
dont need to check for positionId again
Comment on lines
+177
to
+181
| rangeLow={0.34} | ||
| rangeHigh={0.66} | ||
| value={Number(fee)} | ||
| valueDisplay={feeDisplay} | ||
| range={[0.01, 0.34, 0.66, 1]} |
Collaborator
There was a problem hiding this comment.
extract these numbers to separate const, since you are using them in multiple places
const FEE_RANGE = {
low: 0.34,
high: 0.66,
full: [0.01, 0.34, 0.66, 1] as const,
}| mutationFn: async (): Promise<void> => { | ||
| if (!receiveAssetsProportionally) | ||
| throw new Error("Receive assets not found") | ||
| if (!receiveAssets) throw new Error("Receive assets not found") |
Collaborator
There was a problem hiding this comment.
doesnt look like you need this check, since receiveAssets from useMemo is always an array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.