fix: Apply text opacity to outline in ML#334
Merged
Merged
Conversation
There's no mention of this in Maplibre docs but from my testing it seems that Maplibre applies text opacity to the outline also. This commit applies this logic when converting Maplibre style into Galileo style rules. It also modifies `WithOpacity` expression to blend alpha value insted of replacing it, as it seems to be closer to what Maplibre does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no mention of this in Maplibre docs but from my testing it seems
that Maplibre applies text opacity to the outline also. This commit
applies this logic when converting Maplibre style into Galileo style
rules. It also modifies
WithOpacityexpression to blend alpha valueinsted of replacing it, as it seems to be closer to what Maplibre does.