Refactor codebase to a data driven format#807
Draft
BuffYoda21 wants to merge 9 commits intogamestabled:mainfrom
Draft
Refactor codebase to a data driven format#807BuffYoda21 wants to merge 9 commits intogamestabled:mainfrom
BuffYoda21 wants to merge 9 commits intogamestabled:mainfrom
Conversation
Contributor
Author
|
Went ahead and pushed commit 3b5823d and a32fa39 for the sake of having them here. It currently has an issue that causes a crash during seed generation a few frames after displaying Just to clarify, everything works perfectly up until commit a3fe894 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very big change but I believe this is the best way to ensure maintainability and scalability as the project grows. The json files used here can also be used for an eventual archipelago implementation making maintaining parody between the standalone and AP randomizers much easier. Currently plan to convert the following to be data driven (but will add to this list as necessary):