Sanitize analytics payloads to prevent circular JSON errors#7
Draft
gansxx wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TypeError: Converting circular structure to JSONwhenJSON.stringifyis attempted.Description
lib/analytics-sanitize.tswhich convertsEventandHTMLElementvalues into JSON-safe metadata, strips React internal keys, guards against circular references, enforces max depth, array length and string length limits, and normalizes keys.dataLayerinlib/gtm/utils.tsby callingsanitizeAnalyticsPropertiesand pushing only the sanitized object.gtag) and PostHog: updatelib/analytics.tsto use sanitizedsafeParams, andlib/posthog.tsto forward sanitized properties toposthog.capture.components/AppStoreCard.tsxto avoid nested<a>elements by moving the icon/name outside the anchor and linking the downloadButtondirectly to the externalhref.Testing
pnpm buildcompleted successfully (Next.js production build and static generation succeeded). ✅pnpm exec tsc --noEmitstill reports unrelated pre-existing type errors in other parts of the repo (e.g.OrdersTable,subscription-error-alert,subscription-api) and therefore did not fully pass here.pnpm lint(next lint) is interactive in this repo and could not complete automatically in CI; it did not run to completion.Codex Task