Speed up one test in MoreNaming.tst#509
Merged
Merged
Conversation
SoongNoonien
reviewed
Jul 7, 2026
|
|
||
| # Singer cycle normalizers in prime dimension should not be named as SL | ||
| gap> grp := ClassicalMaximals("L",7,3)[7];; | ||
| gap> Size(grp); |
Collaborator
There was a problem hiding this comment.
Why not here as well?
Member
Author
There was a problem hiding this comment.
we could but it takes about the same either way for this small example (70 vs 60 milliseconds on my machine)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #509 +/- ##
=======================================
Coverage 86.51% 86.51%
=======================================
Files 45 45
Lines 19262 19262
=======================================
Hits 16665 16665
Misses 2597 2597 🚀 New features to boost your workflow:
|
SoongNoonien
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.