Skip to content

Remove some dead code#513

Merged
fingolfin merged 1 commit into
masterfrom
mh/rm-dead-tensor-code
Jul 9, 2026
Merged

Remove some dead code#513
fingolfin merged 1 commit into
masterfrom
mh/rm-dead-tensor-code

Conversation

@fingolfin

Copy link
Copy Markdown
Member

Note that the functions related to involutions are all in orb, without the 'RECOG.' prefix.

Note that the functions related to involutions are all in orb,
without the 'RECOG.' prefix.
@fingolfin
fingolfin requested a review from Till-Eisen July 9, 2026 09:33
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.51%. Comparing base (e1c7faf) to head (29de129).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #513   +/-   ##
=======================================
  Coverage   86.51%   86.51%           
=======================================
  Files          45       45           
  Lines       19262    19262           
=======================================
  Hits        16665    16665           
  Misses       2597     2597           
Files with missing lines Coverage Δ
gap/projective/tensor.gi 59.43% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin

Copy link
Copy Markdown
Member Author

@Till-Eisen please have a look if you see anything in there you feel could still be useful (don't worry, though: even if you miss something, it's of course all still in the history)

@Till-Eisen

Copy link
Copy Markdown
Collaborator

@fingolfin Yes, I have.
RECOG.FindTensorOtherFactor is clearly incomplete: it has no return statement other than fail (and more is missing), so it looks like it was only implemented halfway.
RECOG.VerifyTensorDecomposition looks like it could be useful, but it's not called anywhere either...
And the rest is related to involutions, i.e. in orb as you said.

@fingolfin
fingolfin merged commit 15f685c into master Jul 9, 2026
5 checks passed
@fingolfin
fingolfin deleted the mh/rm-dead-tensor-code branch July 9, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants