Fix SL godown eigenspace dimension check#516
Conversation
This prevents non-invariant spaces from reaching LinearAction. Co-authored-by: Codex <codex@openai.com>
|
This fixes a very rare error, but it occurred in PR #512 (due to bad luck). Codex came up with a slightly different "fix" first, but after some back and forth, we settled on this. I think the main difference is that before, it could happen that all eigenspaces have dimension 1, but we really also want an eigenspace of dimension 3 (when |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #516 +/- ##
=======================================
Coverage 86.51% 86.51%
=======================================
Files 45 45
Lines 19262 19262
=======================================
Hits 16665 16665
Misses 2597 2597
🚀 New features to boost your workflow:
|
| gap> seed:=1;; | ||
| gap> Reset(GlobalMersenneTwister, seed);; | ||
| gap> Reset(GlobalRandomSource, seed);; | ||
| gap> h := GL(6,8);; |
There was a problem hiding this comment.
I could see the case
Perhaps
There was a problem hiding this comment.
In fact also
Co-authored-by: Torben Wiedemann <7226617+TWiedemann@users.noreply.github.com>
This prevents non-invariant spaces from reaching LinearAction.
Co-authored-by: Codex codex@openai.com