Move presentations for S_n/A_n to a new central file#518
Open
TWiedemann wants to merge 5 commits into
Open
Conversation
Collaborator
Author
|
Not sure if the CI fails are related to my changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presentations were already there in
giant.gi. Since they are also needed inSnAnUnknownDegree.gi, I moved them to a new filepresentation.giinbase.Maybe the file
presentation.giwill contain some more presentations in the future. Maybe this will not be necessary since we have theclassicprespackage (#338), and then it might be renamed or merge into another file.I also expanded the presentations to cover small edge cases. Currently they are not used (
giant.giis fordeg>=8andSnAnUnknownDegree.giis fordeg>=7).The tests are of a purely mathematical nature (check whether the presentations given in the paper are correct for small n, or at least yield groups with the correct size), so it is not really necessary to perform them often, but they are fast (42 ms on my laptop).