Skip to content

Commit

Permalink
chore(python): upgrade as high as it works
Browse files Browse the repository at this point in the history
There are some limitations. Docs have an open issue dask/dask-sphinx-theme#68 which locks us on python 3.11.

Chartpress (https://github.com/jupyterhub/chartpress) limits us from going above 3.12 on the helm builds.

Issue dask#850
  • Loading branch information
gardleopard committed Jan 21, 2025
1 parent 3a53345 commit 5375bfc
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 8 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/build-publish-docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: "3.11"
# ref https://github.com/dask/dask-sphinx-theme/issues/68

- name: Install Python docs requirements
run: |
Expand All @@ -64,7 +65,7 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: "3.11"

# ref https://github.com/dask/dask-sphinx-theme/issues/68
- name: Install Python docs requirements
run: |
DASK_GATEWAY_SERVER__NO_PROXY=true pip install -r docs/requirements.txt
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/build-publish-helm-chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ jobs:
fetch-depth: 0
- uses: actions/setup-python@v5
with:
python-version: "3.11"
python-version: "3.12"
# we need chartpress to have a release with https://github.com/jupyterhub/chartpress/commit/28836338679ffff951ea746371b5d18ceca552e0 before this can be 3.13


- name: Install chart publishing dependencies (chartpress, pyyaml, helm)
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-publish-python-packages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
- uses: actions/setup-go@v5
- uses: actions/setup-python@v5
with:
python-version: "3.11"
python-version: "3.13"

- name: Install build package
run: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
--volume=$PWD:/opt/${{ matrix.image }} \
--workdir=/opt/${{ matrix.image }} \
--user=root \
python:3.11-slim-bullseye \
python:3.13-slim-bullseye \
sh -c 'pip install pip-tools==6.* && pip-compile --upgrade --output-file=Dockerfile.requirements.txt Dockerfile.requirements.in'
- name: git diff
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ jobs:
# we test integration with. We can test against only one version and
# that would be fine.
#
- python-version: "3.10"
- python-version: "3.12"
go-version: "1.20"
- python-version: "3.11"
- python-version: "3.13"
go-version: "1.20"
- python-version: "3.12"
go-version: "1.21"
Expand Down Expand Up @@ -166,7 +166,8 @@ jobs:
fetch-depth: 0
- uses: actions/setup-python@v5
with:
python-version: "3.11"
python-version: "3.12"
# we need chartpress to have a release with https://github.com/jupyterhub/chartpress/commit/28836338679ffff951ea746371b5d18ceca552e0 before this can be 3.13

# Starts a k8s cluster with NetworkPolicy enforcement and installs both
# kubectl and helm
Expand Down
2 changes: 1 addition & 1 deletion dev-environment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ name: dask-gateway-dev
channels:
- conda-forge
dependencies:
- python=3.11
- python=3.13
- pip

# Golang with compiler is required to compile dask-gateway-server's bundled
Expand Down

0 comments on commit 5375bfc

Please sign in to comment.