fix(doctor): correct command syntax in graph_coverage warn message#687
Closed
brandonlipman wants to merge 1 commit into
Closed
fix(doctor): correct command syntax in graph_coverage warn message#687brandonlipman wants to merge 1 commit into
brandonlipman wants to merge 1 commit into
Conversation
graph_coverage warn directs users to run `gbrain link-extract && gbrain timeline-extract`, but no commands by those names are registered in cli.ts. The actual commands are `gbrain extract links` and `gbrain extract timeline` (registered as the 'extract' subcommand at src/cli.ts:525, with the kind argument 'links' / 'timeline' / 'all' parsed inside src/commands/extract.ts). A user who runs the suggested command gets: $ gbrain link-extract Unknown command: link-extract This is the only place in src/ with the wrong syntax — the rest of the docs (init.ts:221, init.ts:331, features.ts:120, v0_13_0.ts:67, sync.ts:752 comment) all already say 'extract links'. This patch just brings doctor.ts in line.
5 tasks
Owner
|
Closing — your fix landed in master via the v0.30.3 fix-wave PR #776 (merged at Thank you for the contribution — credit is preserved in the v0.30.3 CHANGELOG entry. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
graph_coveragedoctor check tells users to run commands that don't exist:The actual commands are
gbrain extract linksandgbrain extract timeline(registered as theextractsubcommand atsrc/cli.ts:525, with the kind argumentlinks/timeline/allparsed insidesrc/commands/extract.ts).Fix
One-character change in
src/commands/doctor.ts:588:This is the only place in
src/with the wrong syntax — every other reference to extract commands (init.ts:221,init.ts:331,features.ts:120,migrations/v0_13_0.ts:67, thesync.ts:752comment) already usesextract links/extract timeline. This brings doctor in line.Test
test/doctor.test.ts— 15 pass, 0 fail.Need help on this PR? Tag
@codesmithwith what you need.