fix(migrations): harden v0.29.1 on PGLite + guard effective_date index creation#743
Closed
DrBaher wants to merge 1 commit into
Closed
Conversation
5 tasks
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes two migration hardening issues seen on PGLite upgrades:
v0.29.1 orchestrator used an engine before connecting
PGLite not connected. Call connect() first.phaseBBackfillandphaseCVerifynow callconnectWithRetry(...)before DB work anddisconnect()afterwards.Schema bootstrap could reference
effective_datetoo earlypages_coalesce_date_idxcould fail ifpages.effective_datewas not yet present.Files changed
src/commands/migrations/v0_29_1.tssrc/core/schema-embedded.tssrc/core/pglite-schema.tssrc/schema.sqlVerification
bun run typecheck0.29.1; with this change, migration completed and doctor advanced fromunhealthytowarningswith schema at latest.Need help on this PR? Tag
@codesmithwith what you need.