fix(review): add PR type triage for non-application PRs#645
Open
gregario wants to merge 2 commits intogarrytan:mainfrom
Open
fix(review): add PR type triage for non-application PRs#645gregario wants to merge 2 commits intogarrytan:mainfrom
gregario wants to merge 2 commits intogarrytan:mainfrom
Conversation
Add Step 3.5 to classify PRs by type (application, CI/infra, scripts, config, docs, tests, mixed) and guide which review categories to prioritize. Prevents false-confidence N/A results on non-application PRs. Add three new Pass 2 checklist categories: - Script & Shell Quality: shell options, shebangs, quoting, portability - Platform & Convention Consistency: toolchain matching, naming conventions - Configuration & Infrastructure Safety: hardcoded secrets, CI triggers Closes garrytan#356 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Plants 3 issues in a CI workflow (pull_request_target without SHA pinning, hardcoded token, chmod 777 on Windows runner) and verifies the review catches at least 2 of 3. Registered as gate tier — CI security issues should always be caught. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #356 —
/reviewblindspot on non-application code PRs.pull_request_targetwithout SHA pinning,chmod 777, Docker tag pinningpull_request_target, hardcoded token,chmod 777on Windows runner) and verifies the review catches at least 2/3.Test plan
bun testpasses (Tier 1 static validation)review-ci-blindspot(gate tier)bun run gen:skill-docsregenerates cleanlyEVALS=1 bun test test/skill-e2e-review.test.ts(requires API key)Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com