fix: unblock stalled workflow control reconciliation#678
Merged
julianknutsen merged 2 commits intofix/track1-gascity-example-pack-schemafrom Apr 15, 2026
Merged
Conversation
github-actions
bot
added
the
status/needs-triage
julianknutsen
force-pushed
the
fix/scoped-terminal-reconcile
branch
from
649e2fd to
bc2c9b3
Compare
- close enclosing scope bodies when retry / ralph control beads finish terminally, not just from fanout paths - propagate non-`gc.*` member metadata when a scope auto-closes through terminal-member reconciliation - let built-in `control-dispatcher` workers claim legacy `workflow-control` routes / assignees so pre-rename workflows keep moving Squashed rebase of PR #678 (commits 9acb796 + bc2c9b3) onto current main, extracting only the two intentional commits from a branch that had diverged by ~118 unrelated commits.
Three maintainer fixups from the adoption review: 1. controller_error paths now reconcile enclosing scope. When spawnNextAttempt fails inside a scoped retry/ralph, the control bead was closing with gc.final_disposition=controller_error but never reconciling the scope body — the exact stall this PR aims to remove. Added reconcileClosedScopeMember calls after both controller_error close sites. 2. Metadata propagation now runs on scope-fail auto-close, not just scope-pass. reconcileTerminalScopedMember's fail branch now calls propagateScopeMemberMetadata before setOutcomeAndClose so review.verdict / review.summary-style metadata survives failure auto-close instead of being dropped. 3. GC_SESSION_ORIGIN ephemeral-only gate is now scoped to control-dispatchers (legacy branch) only. The non-legacy branch in EffectiveWorkQuery preserves main's prior Tier 3 behavior for persistent sessions — demand-detection restrictions only apply to control-dispatcher workers, not every agent. Tests pass: internal/config, internal/dispatch.
julianknutsen
force-pushed
the
fix/scoped-terminal-reconcile
branch
from
bc2c9b3 to
739fbdb
Compare
julianknutsen
changed the base branch from
main
to
fix/track1-gascity-example-pack-schema
julianknutsen
merged commit 1bfd8b3
into
fix/track1-gascity-example-pack-schema
13 checks passed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gc.*member metadata when a scope auto-closes through terminal-member reconciliationcontrol-dispatcherworkers claim legacyworkflow-controlroutes / assignees so pre-rename workflows keep movingThis was driven by live workflow stalls in the
gastore:gc.kind=scopebody open forever after terminal retry / ralph members closedworkflow-control/gascity/workflow-control, while the runtime only wokecontrol-dispatcherTesting
make checkmake check-docsif docs, navigation, or links changedmake test-integrationif runtime, controller, or workflow behavior changedAdditional validation:
internal/dispatchfor retry / ralph terminal scope reconciliationinternal/configtests provingcontrol-dispatcherwork queries claim legacyworkflow-controlassignees and routesgastore:ga-qljmkm, thengc convoy control ga-vc6558resumed the loop (action=retry created=1)ga-rwpb6processed under the new pathga-4ujzprocessed togc.outcome=passChecklist
workflow-controlmetadata.