Stabilize track1 RC regressions for packs upmerge#703
Closed
julianknutsen wants to merge 5 commits intocodex/integration-track1-upmerge-local-snapshot-20260414from
Closed
Stabilize track1 RC regressions for packs upmerge#703julianknutsen wants to merge 5 commits intocodex/integration-track1-upmerge-local-snapshot-20260414from
julianknutsen wants to merge 5 commits intocodex/integration-track1-upmerge-local-snapshot-20260414from
Conversation
b61c180 to
fcf5eb9
Compare
fcf5eb9 to
8d29d4c
Compare
9da757b to
c6081e5
Compare
8d29d4c to
8cb8922
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR packages the RC-gate stabilization work needed before merging back into
codex/integration-track1-upmerge. It addresses the checked-in failure buckets from Actions run24362910139.1. Command discovery and docs drift
docs/packv2.2. V2 agent scaffolding expectations
gc agent addacceptance coverage and txtar fixtures to current v2 city behavior.pack.toml+agents/<name>/scaffolding instead of legacycity.tomlmutation.3. macOS rig/workdir path normalization
/varvs/private/vardo not break hook and rig resolution.4. Workflow pool and retry recovery
issue_type=molecule.5. Integration harness and fixture alignment
gc.attemptwhere the current check scripts require it.filebdshimreadypath use real ready filtering so session beads are excluded.Breaking changes / migration notes
gc agent addcontract rather than the removed legacy behavior.Testing
make checkRan:
make checkmake check-docsif docs, navigation, or links changedRan:
make check-docsmake test-integrationif runtime, controller, or workflow behavior changedI did not run the full
make test-integrationtarget. I reran the failing workflow/controller buckets directly:Additional targeted verification:
go test ./cmd/gc -run 'TestAddDiscoveredCommandsToRoot|TestTutorial01|TestRigAnywhere_RigFromCwdDir|TestCmdHookUsesAgentCityAndRigRoot|TestCmdHookPoolInstanceUsesTemplatePoolLabel|TestRigAnywhere_ResolveContext|TestRigAnywhere_ResolveRigToContext' -count=1go test ./internal/workdir -run 'TestConfiguredRigNameMatchesSymlinkAliasPath' -count=1go test ./test/docsync -count=1go test -tags acceptance_a -timeout 5m ./test/acceptance -run 'TestAgentAddCommands|TestAgentSuspendResume|TestConvergeCommands/List_JSON_ReturnsArray|TestSessionEmptyCity/List_JSON|TestStatusTutorialCity/JSON_ReturnsValidJSON|TestFormulaCommands/Show_GastownFormula_DisplaysSteps|TestOrderGastownCity/Show_DisplaysDetails' -count=1go test ./internal/molecule ./test/integration/filebdshim -count=1go test -tags integration ./test/integration -run 'TestRetryManagedPooledWorkerRecoversClaimedAttemptAfterCrash' -count=1 -timeout 12m -vgo test -tags integration ./test/integration -run 'TestGraphWorkflowSuccessPath|TestGraphWorkflowFailureRunsCleanup|TestAdoptPRFormulaCompileAndRun|TestPersonalWorkFormulaCompileAndRun|TestRetryManagedPooledWorkerRecoversClaimedAttemptAfterCrash' -count=1 -timeout 30m -vChecklist
Tracked in
bdasga-7wbjg3.